Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move full text extraction to hydra:derivatives #220

Closed
elrayle opened this issue Oct 5, 2015 · 3 comments
Closed

move full text extraction to hydra:derivatives #220

elrayle opened this issue Oct 5, 2015 · 3 comments

Comments

@elrayle
Copy link
Contributor

elrayle commented Oct 5, 2015

It is desirable to have all derivative generation code in hydra:derivatives to create a single API for generating derivatives. This allows for the generation of derivatives to be configured by filetype in #makes_derivatives in file derivatives.rb.

The process for a hydra-works based app to override #makes_derivatives needs to be defined and documented.

This will likely replace the service oriented approach for derivatives including Hydra::Works::GenerateThumbnail and proposed Hydra::Works::GenerateExtractedText (see PR #213).

QUESTIONS:
Looking at Hydra::Works::GenerateThumbnail, object.build_thumbnail is called prior to calling object.create_derivatives.

  • Do files need to be created prior to calling #create_derivatives for all potential derivatives?
  • How would the app know which files (e.g. #build_thumbnail, #build_extracted_text) to create since it may vary based on the generic file's primary content type?
  • Is it possible to do this automatically based on the configuration of setup in #make_derivatives
@elrayle
Copy link
Contributor Author

elrayle commented Oct 5, 2015

Related discussion in issue #215

@jcoyne
Copy link
Member

jcoyne commented Oct 5, 2015

I'm for moving full text extraction to hydra derivatives. Please note that makes_derivatives has already been removed from the API. I think the object.build_* belongs in the output file service that you pass to the Hydra::Derivatives Runner.

@jcoyne
Copy link
Member

jcoyne commented Oct 7, 2015

Closed by #228

@jcoyne jcoyne closed this as completed Oct 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants