Ensure files have been added before proxy depositor set. Add a test.

samvera · Mar 18, 2022 · 5aa3758 · 5aa3758
1 parent 8370f27
commit 5aa3758
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/lib/hyrax/transactions/work_create.rb b/lib/hyrax/transactions/work_create.rb
@@ -13,8 +13,8 @@ class WorkCreate < Transaction
                        'change_set.set_user_as_depositor',
                        'change_set.apply',
                        'work_resource.save_acl',
-                       'work_resource.change_depositor',
                        'work_resource.add_file_sets',
+                       'work_resource.change_depositor',
                        'work_resource.add_to_parent'].freeze
 
       ##

diff --git a/spec/hyrax/transactions/work_create_spec.rb b/spec/hyrax/transactions/work_create_spec.rb
@@ -53,5 +53,21 @@
           .to have_file_set_members(be_persisted, be_persisted, be_persisted, be_persisted)
       end
     end
+
+    context 'when providing a proxy_depositor' do
+      let(:user) { FactoryBot.create(:user) }
+      let(:on_behalf_of) { FactoryBot.create(:user) }
+      let(:resource) { build(:hyrax_work, depositor: user.user_key) }
+
+      it 'sets the given user as depositor, old depositor as proxy_depositor' do
+        tx.with_step_args('work_resource.change_depositor' => { user: on_behalf_of })
+
+        expect(tx.call(change_set).value!)
+          .to have_attributes(
+            proxy_depositor: user.user_key,
+            depositor: on_behalf_of.user_key
+          )
+      end
+    end
   end
 end