Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Home page language selector change, update lang selector #2980

Closed
1 task
adamjarling opened this issue Apr 30, 2018 · 0 comments
Closed
1 task

Home page language selector change, update lang selector #2980

adamjarling opened this issue Apr 30, 2018 · 0 comments
Assignees
@adamjarling
Labels
accessibility-concern priority
Projects
Hyrax WG -- Sprint 2 Hyrax WG -- Sprint 3
Milestone
Accessibility

Comments

@adamjarling
Copy link
Member

Descriptive summary

From Accessibility360 audit report:

When the language is changed on the site, the "lang" attribute is not changed.
When the language is changed, ensure that the lang attribute on the html tag reflects the primary language.

Click link below for video:
https://screencast.com/t/xBnEPGQDOK

Tasks

  • Add a JavaScript event listener on language change select, and update the DOM.

Rationale

Accessibility improvement.

Expected behavior

When a new language is selected, the <html lang="" /> attribute updates to reflect the new language.

Actual behavior

See video link above. Selecting a new language doesn't update lang attribute in the DOM.

Steps to reproduce the behavior

  1. Go to Hyrax homepage.
  2. Select a new language and observe the DOM in browser's console "Elements" tab.
@adamjarling adamjarling added this to the 2.x - Accessibility milestone Apr 30, 2018
@no-reply no-reply added this to Backlog in Hyrax WG -- Sprint 2 via automation Jul 30, 2018
@chrisdaaz chrisdaaz moved this from Backlog to Ready in Hyrax WG -- Sprint 2 Jul 30, 2018
@adamjarling adamjarling self-assigned this Aug 13, 2018
@adamjarling adamjarling moved this from Ready to In progress in Hyrax WG -- Sprint 2 Aug 13, 2018
@no-reply no-reply added this to In progress in Hyrax WG -- Sprint 3 Sep 4, 2018
@adamjarling adamjarling mentioned this issue Sep 5, 2018
Merged
@adamjarling adamjarling moved this from In progress to Review in Hyrax WG -- Sprint 3 Sep 6, 2018
Hyrax WG -- Sprint 3 automation moved this from Review to Done Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamjarling adamjarling

Labels
accessibility-concern priority
Projects
No open projects
Hyrax WG -- Sprint 2
  
In progress
Hyrax WG -- Sprint 3
  
Done
Milestone
Accessibility
Development

No branches or pull requests
3 participants
@no-reply @adamjarling @h-parekh