Handle language change update in javascript to update html lang attri… #3235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
requested changes
Sep 5, 2018
| this.addLangClickListener(); | ||
| } | ||
|
|
||
| addLangClickListener() { |
There was a problem hiding this comment.
Can you add documentation that explains what this method is doing?
There was a problem hiding this comment.
Yea no problem. I just updated the file. This function handles the event of changing (by clicking), a new language in the top bar language selector dropdown. And the thought was the class InternationalizationHelper.js could serve as a generic, helper class to organize internationalization event handling.
adamjarling
force-pushed
the
2980-home-page-language-selector-update
branch
from
3b40f61
to
4da4faf
Compare
jcoyne
reviewed
Sep 5, 2018
| } | ||
|
|
||
| /** | ||
| * Handle the event of selecting a new language from top bar, language select element. |
There was a problem hiding this comment.
Would you also add, "this updates the html@lang attribute which is important for screen readers"?
There was a problem hiding this comment.
Sure, just added the text.
adamjarling
force-pushed
the
2980-home-page-language-selector-update
branch
from
4da4faf
to
41a0c54
Compare
jcoyne
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…bute
Fixes #2980
Updates the
<html lang="" />attribute when a new language is selected from the dropdown.@samvera/hyrax-code-reviewers