Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misplaced header closing tag breaks the layout of the public collections show view #4518

Closed
jzimpel opened this issue Sep 14, 2020 · 1 comment · Fixed by #4533
Closed

Misplaced header closing tag breaks the layout of the public collections show view #4518

jzimpel opened this issue Sep 14, 2020 · 1 comment · Fixed by #4533
Assignees

Comments

@jzimpel
Copy link
Contributor

jzimpel commented Sep 14, 2020

Descriptive summary

The public collections show view breaks the default layout. The footer is not centered any more and has moved to the right.
In the source view the Browser reports a misplaced header closing tag.

Tested on 3.0.0.pre.rc2 in Firefox and Opera.

Steps to reproduce the behavior

Open the public show view of a collection (/collections/:id).

Bildschirmfoto 2020-09-14 um 19 06 02

@jzimpel
Copy link
Contributor Author

jzimpel commented Sep 15, 2020

The misplaced header closing tag can be found in app/views/hyrax/collections/show.html.erb L. 50.
Should be a closing div tag.

@jeremyf jeremyf self-assigned this Oct 6, 2020
jeremyf added a commit that referenced this issue Oct 6, 2020
In the commit 2f880a6, we changed from
opening a HEADER tag to opening a DIV tag.  However, we did not changing
the matching closing HEADER to a closing DIV.  This commit fixes that.

Closes #4518

Related to #4150
jeremyf added a commit that referenced this issue Oct 6, 2020
In the commit 2f880a6, we changed from
opening a HEADER tag to opening a DIV tag.  However, we did not changing
the matching closing HEADER to a closing DIV.  This commit fixes that.

Closes #4518

Related to #4150
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants