Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can recommended FITS version be updated to 1.2.0+? #4815

Closed
kerchner opened this issue Mar 19, 2021 · 1 comment · Fixed by #4816
Closed

Can recommended FITS version be updated to 1.2.0+? #4815

kerchner opened this issue Mar 19, 2021 · 1 comment · Fixed by #4816
Labels
documentation
Milestone
2.x series

Comments

@kerchner
Copy link
Contributor

Descriptive summary

The latest version of https://github.com/samvera/hyrax/blob/e21dc432b2a1cbdf6ce44f5494353fbb291ba9c5/documentation/developing-your-hyrax-based-app.md still recommends FITS version 1.0.5. Although I personally have not tested it, based on this thread harvard-lts/fits#140 (comment) it looks like the issue is fixed in FITS 1.2.0+

Rationale

Deployments following the recommendations will be able to take advantage of improvements in FITS since 1.0.5.
@no-reply
Copy link
Contributor

yes. even our own docker build installs 1.5.0.

could you submit a pull request?

@no-reply no-reply added this to the 2.x series milestone Mar 19, 2021
kerchner added a commit to kerchner/hyrax that referenced this issue Mar 19, 2021
@kerchner
Update recommended FITS version
17c16db 
Fixes samvera#4815
@kerchner kerchner mentioned this issue Mar 19, 2021
Merged
no-reply pushed a commit that referenced this issue Mar 19, 2021
@kerchner
Update recommended FITS version
534f523 
Fixes #4815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
2.x series
Development

Successfully merging a pull request may close this issue.

Update recommended FITS version kerchner/hyrax
2 participants
@no-reply @kerchner