Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove icons from the Works dashboard "actions" dropdown menu #5506

Closed
sdellis opened this issue Mar 8, 2022 · 2 comments · Fixed by #5508
Closed

Remove icons from the Works dashboard "actions" dropdown menu #5506

sdellis opened this issue Mar 8, 2022 · 2 comments · Fixed by #5508

Comments

@sdellis
Copy link
Contributor

sdellis commented Mar 8, 2022

Descriptive summary

The icons in the Works dashboard "actions" dropdown menu are inconsistent with the "actions" dropdown in the Collection dashboard. Given that the icons are not enhancing the accessibility in any way, they should be removed. This is only a UI change as it does not affect backend models.

Related work

Ref #5490

@sdellis
Copy link
Contributor Author

sdellis commented Mar 9, 2022

@jlhardes I know you already approved this on Slack, but for the record can you also 👍 the removal of the icons here? Thank you!

@jlhardes
Copy link
Contributor

jlhardes commented Mar 9, 2022

I am OK with this change to remove the icons from the Works Select menu in the Dashboard since there’s no accessibility aid to including the icons and we aren’t introducing any backwards-compatibility issues by taking out those icons. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Hyrax-Valkyrization
Ready to be Archived
Development

Successfully merging a pull request may close this issue.

3 participants