Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"hyrax/pcdm" verbiage appears in label for Relations section of work view page (nurax-pg) #5587

Closed
eporter23 opened this issue Mar 29, 2022 · 0 comments · Fixed by #5625
Closed

Comments

@eporter23
Copy link
Contributor

Descriptive summary

In nurax-pg QA testing, the Relations > In Collection heading label text has changed and now says "In Hyrax/pcdm collection".

Rationale

Per existing Hyrax functionality, this label should say "In Collection". "Hyrax/pcdm" will not be meaningful to most users.

Expected behavior

Label should say "In Collection:"

Screen Shot 2022-03-29 at 3 08 22 PM

Actual behavior

Heading says "In Hyrax/pcdm collection:"

Screen Shot 2022-03-29 at 3 07 19 PM

Steps to reproduce the behavior

  1. Go to the Dashboard > Works and locate a work contained in a collection
  2. Open the work in the view work page
  3. Scroll down to the Relations section
  4. See the heading text displayed
no-reply pushed a commit that referenced this issue May 12, 2022
when grouping relationship presenters for display in the show view, calling
`#to_s` results in a Ruby style model name. we want to display the human name,
which `ActiveModel` supports via `#human`.

the view also calls `String#humanize` which should be a no-op in most cases
after this, but still seems appropriate.

fixes #5587.
no-reply pushed a commit that referenced this issue May 12, 2022
when grouping relationship presenters for display in the show view, calling
`#to_s` results in a Ruby style model name. we want to display the human name,
which `ActiveModel` supports via `#human`.

the view also calls `String#humanize` which should be a no-op in most cases
after this, but still seems appropriate.

fixes #5587.
no-reply pushed a commit that referenced this issue May 12, 2022
when grouping relationship presenters for display in the show view, calling
`#to_s` results in a Ruby style model name. we want to display the human name,
which `ActiveModel` supports via `#human`.

the view also calls `String#humanize` which should be a no-op in most cases
after this, but still seems appropriate.

fixes #5587.
no-reply pushed a commit that referenced this issue May 12, 2022
when grouping relationship presenters for display in the show view, calling
`#to_s` results in a Ruby style model name. we want to display the human name,
which `ActiveModel` supports via `#human`.

the view also calls `String#humanize` which should be a no-op in most cases
after this, but still seems appropriate.

fixes #5587.
no-reply pushed a commit that referenced this issue May 12, 2022
when grouping relationship presenters for display in the show view, calling
`#to_s` results in a Ruby style model name. we want to display the human name,
which `ActiveModel` supports via `#human`.

the view also calls `String#humanize` which should be a no-op in most cases
after this, but still seems appropriate.

fixes #5587.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant