New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"hyrax/pcdm" verbiage appears in label for Relations section of work view page (nurax-pg) #5587
Comments
no-reply
pushed a commit
that referenced
this issue
May 12, 2022
when grouping relationship presenters for display in the show view, calling `#to_s` results in a Ruby style model name. we want to display the human name, which `ActiveModel` supports via `#human`. the view also calls `String#humanize` which should be a no-op in most cases after this, but still seems appropriate. fixes #5587.
no-reply
pushed a commit
that referenced
this issue
May 12, 2022
when grouping relationship presenters for display in the show view, calling `#to_s` results in a Ruby style model name. we want to display the human name, which `ActiveModel` supports via `#human`. the view also calls `String#humanize` which should be a no-op in most cases after this, but still seems appropriate. fixes #5587.
no-reply
pushed a commit
that referenced
this issue
May 12, 2022
when grouping relationship presenters for display in the show view, calling `#to_s` results in a Ruby style model name. we want to display the human name, which `ActiveModel` supports via `#human`. the view also calls `String#humanize` which should be a no-op in most cases after this, but still seems appropriate. fixes #5587.
no-reply
pushed a commit
that referenced
this issue
May 12, 2022
when grouping relationship presenters for display in the show view, calling `#to_s` results in a Ruby style model name. we want to display the human name, which `ActiveModel` supports via `#human`. the view also calls `String#humanize` which should be a no-op in most cases after this, but still seems appropriate. fixes #5587.
no-reply
pushed a commit
that referenced
this issue
May 12, 2022
when grouping relationship presenters for display in the show view, calling `#to_s` results in a Ruby style model name. we want to display the human name, which `ActiveModel` supports via `#human`. the view also calls `String#humanize` which should be a no-op in most cases after this, but still seems appropriate. fixes #5587.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Descriptive summary
In nurax-pg QA testing, the Relations > In Collection heading label text has changed and now says "In Hyrax/pcdm collection".
Rationale
Per existing Hyrax functionality, this label should say "In Collection". "Hyrax/pcdm" will not be meaningful to most users.
Expected behavior
Label should say "In Collection:"
Actual behavior
Heading says "In Hyrax/pcdm collection:"
Steps to reproduce the behavior
The text was updated successfully, but these errors were encountered: