Admin Analytic's Work Reports renders in error when attempting to call strftime on a String.
#5818
Comments
jeremyf
added a commit
that referenced
this issue
Aug 29, 2022
Prior to this commit, the view was (rightly) assuming that the `@document.date_uploaded` was a Date-like object (e.g. responded to `strftime`). However, in the wild, we encountered situations where the field was a String (that was of the form "CCYY-MM-DD"). This change introduces a helper method to handle the type negotiation. It also follows on the logic introduced in [Hyrax::StatsUsagePresenter][1]. Closes ##5818 This change should be back-ported to v3.4.x and v3.3.x [1]:https://github.com/samvera/hyrax/blob/27d62a2338bd9e49f942e7e73829f91f2e8115eb/app/presenters/hyrax/stats_usage_presenter.rb#L38-L42
jeremyf
added a commit
that referenced
this issue
Aug 30, 2022
Prior to this commit, the view was (rightly) assuming that the `@document.date_uploaded` was a Date-like object (e.g. responded to `strftime`). However, in the wild, we encountered situations where the field was a String (that was of the form "CCYY-MM-DD"). This change introduces a helper method to handle the type negotiation. It also follows on the logic introduced in [Hyrax::StatsUsagePresenter][1]. Closes ##5818 This change should be back-ported to v3.4.x and v3.3.x [1]:https://github.com/samvera/hyrax/blob/27d62a2338bd9e49f942e7e73829f91f2e8115eb/app/presenters/hyrax/stats_usage_presenter.rb#L38-L42
jeremyf
added a commit
that referenced
this issue
Aug 30, 2022
Prior to this commit, the view was (rightly) assuming that the `@document.date_uploaded` was a Date-like object (e.g. responded to `strftime`). However, in the wild, we encountered situations where the field was a String (that was of the form "CCYY-MM-DD"). This change introduces a helper method to handle the type negotiation. It also follows on the logic introduced in [Hyrax::StatsUsagePresenter][1]. Closes ##5818 This change should be back-ported to v3.4.x and v3.3.x [1]:https://github.com/samvera/hyrax/blob/27d62a2338bd9e49f942e7e73829f91f2e8115eb/app/presenters/hyrax/stats_usage_presenter.rb#L38-L42
jeremyf
added a commit
that referenced
this issue
Aug 31, 2022
Prior to this commit, the view was (rightly) assuming that the `@document.date_uploaded` was a Date-like object (e.g. responded to `strftime`). However, in the wild, we encountered situations where the field was a String (that was of the form "CCYY-MM-DD"). This change introduces a helper method to handle the type negotiation. It also follows on the logic introduced in [Hyrax::StatsUsagePresenter][1]. Closes ##5818 This change should be back-ported to v3.4.x and v3.3.x [1]:https://github.com/samvera/hyrax/blob/27d62a2338bd9e49f942e7e73829f91f2e8115eb/app/presenters/hyrax/stats_usage_presenter.rb#L38-L42
jeremyf
added a commit
that referenced
this issue
Sep 1, 2022
Prior to this commit, the view was (rightly) assuming that the `@document.date_uploaded` was a Date-like object (e.g. responded to `strftime`). However, in the wild, we encountered situations where the field was a String (that was of the form "CCYY-MM-DD"). This change introduces a helper method to handle the type negotiation. It also follows on the logic introduced in [Hyrax::StatsUsagePresenter][1]. Closes ##5818 This change should be back-ported to v3.4.x and v3.3.x [1]:https://github.com/samvera/hyrax/blob/27d62a2338bd9e49f942e7e73829f91f2e8115eb/app/presenters/hyrax/stats_usage_presenter.rb#L38-L42
jeremyf
added a commit
that referenced
this issue
Sep 1, 2022
Prior to this commit, the view was (rightly) assuming that the `@document.date_uploaded` was a Date-like object (e.g. responded to `strftime`). However, in the wild, we encountered situations where the field was a String (that was of the form "CCYY-MM-DD"). This change introduces a helper method to handle the type negotiation. It also follows on the logic introduced in [Hyrax::StatsUsagePresenter][1]. Closes ##5818 This change should be back-ported to v3.4.x and v3.3.x [1]:https://github.com/samvera/hyrax/blob/27d62a2338bd9e49f942e7e73829f91f2e8115eb/app/presenters/hyrax/stats_usage_presenter.rb#L38-L42
jeremyf
added a commit
that referenced
this issue
Sep 1, 2022
Prior to this commit, the view was (rightly) assuming that the `@document.date_uploaded` was a Date-like object (e.g. responded to `strftime`). However, in the wild, we encountered situations where the field was a String (that was of the form "CCYY-MM-DD"). This change introduces a helper method to handle the type negotiation. It also follows on the logic introduced in [Hyrax::StatsUsagePresenter][1]. Closes ##5818 This change should be back-ported to v3.4.x and v3.3.x [1]:https://github.com/samvera/hyrax/blob/27d62a2338bd9e49f942e7e73829f91f2e8115eb/app/presenters/hyrax/stats_usage_presenter.rb#L38-L42
jeremyf
added a commit
that referenced
this issue
Sep 1, 2022
Prior to this commit, the view was (rightly) assuming that the `@document.date_uploaded` was a Date-like object (e.g. responded to `strftime`). However, in the wild, we encountered situations where the field was a String (that was of the form "CCYY-MM-DD"). This change introduces a helper method to handle the type negotiation. It also follows on the logic introduced in [Hyrax::StatsUsagePresenter][1]. Closes ##5818 This change should be back-ported to v3.4.x and v3.3.x [1]:https://github.com/samvera/hyrax/blob/27d62a2338bd9e49f942e7e73829f91f2e8115eb/app/presenters/hyrax/stats_usage_presenter.rb#L38-L42
jeremyf
added a commit
that referenced
this issue
Sep 2, 2022
Prior to this commit, the view was (rightly) assuming that the `@document.date_uploaded` was a Date-like object (e.g. responded to `strftime`). However, in the wild, we encountered situations where the field was a String (that was of the form "CCYY-MM-DD"). This change introduces a helper method to handle the type negotiation. It also follows on the logic introduced in [Hyrax::StatsUsagePresenter][1]. Closes ##5818 This change should be back-ported to v3.4.x and v3.3.x [1]:https://github.com/samvera/hyrax/blob/27d62a2338bd9e49f942e7e73829f91f2e8115eb/app/presenters/hyrax/stats_usage_presenter.rb#L38-L42
dlpierce
added a commit
that referenced
this issue
Sep 2, 2022
dlpierce
pushed a commit
that referenced
this issue
Sep 2, 2022
* Pessimistic handling of non-Date objects Prior to this commit, the view was (rightly) assuming that the `@document.date_uploaded` was a Date-like object (e.g. responded to `strftime`). However, in the wild, we encountered situations where the field was a String (that was of the form "CCYY-MM-DD"). This change introduces a helper method to handle the type negotiation. It also follows on the logic introduced in [Hyrax::StatsUsagePresenter][1]. Closes ##5818 This change should be back-ported to v3.4.x and v3.3.x [1]:https://github.com/samvera/hyrax/blob/27d62a2338bd9e49f942e7e73829f91f2e8115eb/app/presenters/hyrax/stats_usage_presenter.rb#L38-L42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In app/views/hyrax/admin/analytics/work_reports/show.html.erb we have cases where
@document.date_uploadedis not a Date-like object. When that view attempts to callstrftimeon the@document.date_uploadedwe get the following error:undefined method strftime' for "2022-08-10T23:22:45Z":String.Throughout the code base the
@document.date_uploadedis rendered directly (e.g. no conversion). In the Hyrax::StatsUsagePresenter object we do ensure a date like value. Which indicates that this field cannot predicatably be called a Date.Proposal: Add a helper method
cast_to_formatted_date(value, format: "%Y-%m-%d")this would attempt to parse the value from String to date then render with the given format. Port this to the3.4.xand4.0.xbranches.The text was updated successfully, but these errors were encountered: