Remove datatables class from All Works display table, which was causi… #3317
Conversation
| @@ -60,9 +60,9 @@ | |||
| <% elsif current_page?(hyrax.dashboard_works_path(locale: nil)) && !current_ability.admin? %> | |||
| <span class="count-display"><%= I18n.t('hyrax.my.count.works.you_manage', total_count: @response.total_count).html_safe %></span> | |||
| <% else %> | |||
| <span class="count-display"><%= I18n.t('hyrax.my.count.works.in_repo', total_count: @response.total_count).html_safe %></span> | |||
| <span class="count-display"><%= I18n.t('hyrax.my.count.works.in_repo', total_count: @response.total_count).html_safe %></span> | |||
There was a problem hiding this comment.
Should we drop this whitespace-only diff?
| @@ -1,4 +1,4 @@ | |||
| <table class="table table-striped works-list datatable"> | |||
| <table class="table table-striped works-list"> | |||
There was a problem hiding this comment.
Ah, so datatables was added for sorting, but it (from #3173 PR screenshot), looks like it doubled the UI. Is the solution to rip out the existing pagination and search, and let datatables handle pagination, search, and sorting?
There was a problem hiding this comment.
maybe, but i think that is also problematic, because the datatables only work on data in the current page. i think we would also need to change the relevant search builder to make the datatables work over all results. this problem exists elsewhere (e.g. notifications), as well.
the other alternative is to remove datatables and implement our own sorting.
since the original contribution wasn't part of a particular ticket, i'm tempted to suggest we revert it as proposed here and start from scratch. but i'd also like to get @bess (or maybe @mark-dce's) input before moving forward. can either of you comment on the original motivation for this?
…ng double search and pagination
adamjarling
force-pushed
the
3306-remove-extra-pagination-from-dashboard-works
branch
from
ab22d36
to
2397f87
Compare
no-reply
deleted the
3306-remove-extra-pagination-from-dashboard-works
branch
…ng double search and pagination
Fixes #3306
This removes the double search and pagination which was appearing in Works "All Items" page.
After:
Before:
@samvera/hyrax-code-reviewers