Refactor Wings::Valkyrie::ResourceFactory to use a converter class
#3503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
valkyrie-resource-factory-spec
branch
from
b04dbe1
to
fe18304
Compare
revgum
suggested changes
Jan 31, 2019
revgum
previously approved these changes
Jan 31, 2019
no-reply
force-pushed
the
valkyrie-resource-factory-spec
branch
from
1b76743
to
1bafdcd
Compare
no-reply
force-pushed
the
valkyrie-resource-factory-spec
branch
3 times, most recently
from
9672cb0
to
9d4e939
Compare
revgum
previously approved these changes
Feb 1, 2019
Introduces `Wings::ActiveFedoraConverter` and uses it in the `ResourceFactory`. The converter knows how to get an id and attributes to build an AF model for a given `ValkyrieResource`. It currently counts on `#internal_resource` being present, and assumes that the id is the first entry in `#alternate_ids`. We may need to revisit either of these assumptions later.
no-reply
force-pushed
the
valkyrie-resource-factory-spec
branch
from
eac8bc2
to
bf0bf4b
Compare
revgum
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces
Wings::ActiveFedoraConverterand uses it in theResourceFactory. The converter knows how to get an id and attributes to buildan AF model for a given
ValkyrieResource.It currently counts on
#internal_resourcebeing present, and assumes that theid is the first entry in
#alternate_ids. We may need to revisit either ofthese assumptions later.
@samvera/hyrax-code-reviewers