Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove valk 15 monkey patch #3529

Merged
merged 2 commits into from
Feb 6, 2019
Merged

Remove valk 15 monkey patch #3529

merged 2 commits into from
Feb 6, 2019

Conversation

no-reply
Copy link
Member

@no-reply no-reply commented Feb 6, 2019

Remove Wings monkey patches for Valkyrie 1.5.0

@samvera/hyrax-code-reviewers

Upgrade Valkyrie to 1.5.x and remove the internal monkey patch this is no longer
needed.
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the monkey patch is still required in a spec test and thus causing the travis build to fail:

require 'wings/valkyrie_monkey_patch'

This patch is no longer necessary in Valkyrie 1.5.0.
@no-reply
Copy link
Member Author

no-reply commented Feb 6, 2019

@cjcolvar thanks! removed.

Copy link
Contributor

@jeremyf jeremyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the introducer of said monkey patch, and one that tested Hyrax using 1.5.0.RC2, these look good to me.

@no-reply no-reply merged commit 16b1aba into master Feb 6, 2019
@no-reply no-reply deleted the remove-valk-15-monkey-patch branch February 6, 2019 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants