WIP: try optimistic locking system-wide #4326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 20, 2020 17:14
adds an optimistic locking implementation to `Wings` using Fedora's `Last-Modified` property and etags. the existing optimistic locking in the Actor stack counts on etags, so including them in the lock tokens has immediate value. we'll need a strategy for removing them later. for now, this is a fairly naive implementation for early consideration.
sethaj
pushed a commit
to sethaj/hyrax
that referenced
this pull request
May 21, 2020
From [CircleCI build 17168][1] for [PR samvera#4326][2], we encountered an error in which we attempted to `+` together `nil` and a String object. This commit will prevent an application exception when we encounter that behavior. Below is log entry regarding the error. ```log ActionView::Template::Error: undefined method `+' for nil:NilClass # ./app/views/hyrax/homepage/_recent_document.html.erb:7 ``` **Is this appropriate?** I don't know. It looks as though we might want to treat this as in error. But, given some of the challenges we've had with our feature specs, I think I'd prefer that this erratic error not break the build. (Note: When this build broke, Ruby 2.4.7 and 2.6.2 builds of the same code worked) [1]:https://circleci.com/gh/samvera/hyrax/17168#tests/containers/5 [2]:samvera#4236
|
closing this, as we won't likely pursue this until post-Wings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see what happens if we try turning on optimistic locking for all our resources.