Restoring anonymous resource declaration in specs #4493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At issue is "human_readable_type" leverages the resource's model name,
which, by default, uses ActiveModel::Name. By adding `.model_name` that
returns an instance of ActiveModel::Name, the tests now pass.
I could imagine adding a spec helper method for generating an anonymous
resource. This method would encapsulate the behavior. If we were to go
this route, we'd want to update all of our existing `Class.new` declarations.
```ruby
module Hyrax::SpecSupport
def self.build_anonymous_resource_class(klass, name: "Anonymous", &block)
Class.new(klass) do
def self.model_name
ActiveModel::Name.new(self, nil, name)
end
instance_exec(&block)
end
end
end
Hyrax::SpecSupport.build_anonymous_resource_class(Hyrax::Work, name: "Anonymouse") do
include Hyrax::Schema(:basic_metadata)
end
```
elrayle
reviewed
Sep 2, 2020
Comment on lines
+22
to
+24
| def self.model_name | ||
| ActiveModel::Name.new(self, nil, "TemporaryResource") | ||
| end |
There was a problem hiding this comment.
@no-reply Lines 22-24 represent the change from master to address the ArgumentError. Does this change fit with your expectation for code resiliency?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At issue is "human_readable_type" leverages the resource's model name,
which, by default, uses ActiveModel::Name. By adding
.model_namethatreturns an instance of ActiveModel::Name, the tests now pass.
I could imagine adding a spec helper method for generating an anonymous
resource. This method would encapsulate the behavior. If we were to go
this route, we'd want to update all of our existing
Class.newdeclarations.@samvera/hyrax-code-reviewers