Wings: add support for 'count all of model` #4810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elrayle i wonder if you have thoughts about the issue of |
no-reply
force-pushed
the
wings-query
branch
2 times, most recently
from
189bfad
to
7aa9573
Compare
no-reply
force-pushed
the
wings-query
branch
2 times, most recently
from
2455e2f
to
0753fb1
Compare
reduce failing tests for Valkyrie queries to 11. related to #3570
no-reply
force-pushed
the
wings-query
branch
2 times, most recently
from
62d7f25
to
fef1d81
Compare
maybe some small-ish performance optimizations here, but mostly a lot of changes for code readability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduce failing tests for Valkyrie queries to 11.
related to #3570
some refactors are included in a second commit. maybe some small-ish performance optimizations there, but mostly a lot of changes for code readability. please review with that in mind.
@samvera/hyrax-code-reviewers