Make collection-related search builders inherit from the base hyrax collection search builder #4822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 21, 2021 20:47
no-reply
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
thanks for your patience @bkiahstroud.
this looks great! confirming that the test coverage for each of these modules looks pretty robust.
these will all still inherit ::SearchBuilder.
i'm holding merge for a moment to get #4846 out the door.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes all Collection-related
SearchBuilders to inherit from the "base"Hyrax::CollectionSearchBuilder. This allows for consistent behavior across Collection queries as well as less repeated code.@samvera/hyrax-code-reviewers