add logging/warnings when we don't know how to propagate visibility #4831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
null-visibility-prop
branch
from
dccd291
to
34dee54
Compare
in a follow-up to #4516, it became clear that in some cases objects that are neither `WorkBehavior` nor `Hyrax::Resource` are being passed to the visibility propagator. when, and what kinds of objects? this should help us find out.
dlpierce
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in a follow-up to #4516, it became clear that in some cases objects that are
neither
WorkBehaviornorHyrax::Resourceare being passed to the visibilitypropagator.
when, and what kinds of objects? this should help us find out.
@samvera/hyrax-code-reviewers