Gh 4845 settinig lease date in past

[jeremyf]

Release Notes

Fixes #4845. This fix adds both a meaningful error message and renders the correct form controls when you enter an invalid lease date.

Fixing rendering logic for visibility component

e1fd224

Fixes #4845

Prior to this fix, if we had a new record that either set an embargo or
a lease, we would narrow our rendering of the visibility component to
only a partial related to the embargo or lease.

Given a form that set an embargo (or release date)
And that form had invalid data
When I submitted the form
Then the response form would inidicate there was invalid data
And would render only the portion of the visibility related to
  embargo (or release date if set)

With this change, the form renders the entire visibility component,
letting the user change their visibility options (e.g., go from with
Lease to Public or what have you). However, the error messaging is not
providing insight into the problem; That is to say there's a red flash
error, but the content is empty; and there is no indicator on the lease
field that there existed an error. This warrants further work, and will
be a commit that builds on this change.

Adding rendering of lease related error messages

9511dce

Prior to this commit, the form_visibility_error partial did not
include the errors for the :lease_expiration_date nor the
:visibility_after_lease. Per convention of Hyrax, we place the error
messages on the form and not in close DOM proximity to the HTML field
in which we encountered the error.

This relates to #4845

Adjusting lease/embargo_enforced helper logic

adb14ec

This reflects moving the change from e1fd224 — "Fixing rendering logic
for visibility component" into the helper method. This suggestion comes
from no_reply's review comment, and makes sense. I don't think we
want to push the logic further down the stack, as there's a case
statement that would add complexity, as well as it may have unintended
consequences. The change at this level (e.g., a helper method) makes it
more clear that this is for rendering UI components.

Related to #4845.

@samvera/hyrax-repo-managers

[no-reply]

i'm wondering whether the embargo_enforced? helper shouldn't take the new_record? case into account? then this && could be inlined there and kept out of the view?

the other place this is used is _form_permission.html.erb and, at first glance, i'm guessing that partial will have similar issues in the same cases as this one. it might be fair to say that embargo/lease_enforced? isn't true when the object isn't yet saved.

[jeremyf]

This makes sense, and a new commit is incoming!

[no-reply]

fantastic! thanks!