Adding rendering of lease related error messages #4890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `form_visibility_error` partial did not include the errors for the `:lease_expiration_date` nor the `:visibility_after_lease`. Per convention of Hyrax, we place the error messages on the form and not in close DOM proximity to the HTML field in which we encountered the error. This relates to #4845
no-reply
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
Related to #4845, this backport renders error messages related to invalid work lease attributes.
Commit message
Prior to this commit, the
form_visibility_errorpartial did notinclude the errors for the
:lease_expiration_datenor the:visibility_after_lease. Per convention of Hyrax, we place the errormessages on the form and not in close DOM proximity to the HTML field
in which we encountered the error.
This relates to #4845
@samvera/hyrax-code-reviewers