add Valkyrie support to PermissionTemplate#reset_accss_controls_for #5109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
valkyrie-reset-acl
branch
2 times, most recently
from
5f394cd
to
db58e27
Compare
entend PermissionTemplate's valkyrie support by adding handling in with this, it supports Valkyrie and ActiveFedora interchangably.
elrayle
approved these changes
Sep 17, 2021
| edit_groups: edit_groups, | ||
| read_users: read_users, | ||
| read_groups: interpreted_read_groups.uniq) | ||
| end |
elrayle
added a commit
that referenced
this pull request
Jan 31, 2022
…ions for resources * use `Hyrax::query_service` to find `source_model` in `PermissionTemplate` * use `PermissionTemplate #reset_access_controls_for` instead of `AdminSet #reset_access_controls!` The method `Hyrax::AministrativeSet #reset_access_controls!` does not exist. It doesn’t exist for any of the for Valkyrie::Resources. It was replaced by `PermissionTemplate #reset_access_controls_for(collection:)` in PR #5109. This works for both ActiveFedora and Valkyrie.
elrayle
added a commit
that referenced
this pull request
Jan 31, 2022
…ions for resources * use `Hyrax::query_service` to find `source_model` in `PermissionTemplate` * use `PermissionTemplate #reset_access_controls_for` instead of `AdminSet #reset_access_controls!` The method `Hyrax::AministrativeSet #reset_access_controls!` does not exist. It doesn’t exist for any of the for Valkyrie::Resources. It was replaced by `PermissionTemplate #reset_access_controls_for(collection:)` in PR #5109. This works for both ActiveFedora and Valkyrie.
elrayle
added a commit
that referenced
this pull request
Feb 1, 2022
…ions for resources * use `Hyrax::query_service` to find `source_model` in `PermissionTemplate` * use `PermissionTemplate #reset_access_controls_for` instead of `AdminSet #reset_access_controls!` The method `Hyrax::AministrativeSet #reset_access_controls!` does not exist. It doesn’t exist for any of the for Valkyrie::Resources. It was replaced by `PermissionTemplate #reset_access_controls_for(collection:)` in PR #5109. This works for both ActiveFedora and Valkyrie.
elrayle
added a commit
that referenced
this pull request
Feb 1, 2022
…ions for resources * use `Hyrax::query_service` to find `source_model` in `PermissionTemplate` * use `PermissionTemplate #reset_access_controls_for` instead of `AdminSet #reset_access_controls!` The method `Hyrax::AministrativeSet #reset_access_controls!` does not exist. It doesn’t exist for any of the for Valkyrie::Resources. It was replaced by `PermissionTemplate #reset_access_controls_for(collection:)` in PR #5109. This works for both ActiveFedora and Valkyrie.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
entend PermissionTemplate's valkyrie support by adding handling in
with this, it supports Valkyrie and ActiveFedora interchangably.
@samvera/hyrax-code-reviewers