Fix SerializationError in Regenerate Derivatives task #5296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CreateDerivativesJob expects a FileID of type String instead of a Hydra::PCDM::File object. see https://github.com/samvera/hyrax/blob/main/app/jobs/create_derivatives_job.rb#L6 Running the task as-is gives me the following error: ``` RAILS_ENV=production bundle exec rails hyrax:file_sets:regenerate_derivatives [DEPRECATION] PCDM is deprecating 'Class#PreservationMasterFile'. Use Class#PreservationFile instead. rails aborted! ActiveJob::SerializationError: Unsupported argument type: Hydra::PCDM::File ``` This was the simplest change I could make to get the task to run successfully.
no-reply
approved these changes
Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ActiveJob::SerializationError in hyrax:file_sets:regenerate_derivatives task.
CreateDerivativesJob expects a FileID of type String instead of a Hydra::PCDM::File object.
see https://github.com/samvera/hyrax/blob/main/app/jobs/create_derivatives_job.rb#L6
Running the task as-is gives me the following error:
This was the simplest change I could make to get the task to run successfully.
Changes proposed in this pull request:
Guidance for testing, such as acceptance criteria or new user interface behaviors:
@samvera/hyrax-code-reviewers