Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make change set forms allow multiple values for title #5511

Merged
merged 1 commit into from Mar 10, 2022
Merged

Conversation

elrayle
Copy link
Contributor

@elrayle elrayle commented Mar 9, 2022

Per conversation with @jlhardes, work forms should allow for multiple titles to maintain backward compatibility with metadata that already has multiple fields. Otherwise, this presents problems for migrated data.

Prior to this PR

  • work titles could have multiple values
    • this allows multi-valued titles to migrate as multi-valued
  • work form only displays a single field for titles
    • this restricts new works to a single title
    • for existing works with multi-valued title, only one title would be selected for display and there isn't a way for the multiple values to be edited

With this PR

  • work titles can have multiple values (no change)
  • work form also allows for multiple values

@samvera/hyrax-code-reviewers

@jlhardes
Copy link
Contributor

jlhardes commented Mar 9, 2022

This is setting up Valkyrized Works and Collections to allow for multiple Titles which is how metadata is structured for titles in non-Valkyrized Works and Collections. This keeps things moving forward smoothly to allow for upgrading Hyrax versions. Ideally, a migration path might be to select one of the multiple titles as THE title and the other values are moved to Alternative Title but it makes sense for this work to continue to support the capabilities that are currently available, and that includes multiple Titles.

@dlpierce dlpierce merged commit 2fef3db into main Mar 10, 2022
@dlpierce dlpierce deleted the multiple_title branch March 10, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants