call canonicalize instead of canonicalize! for URIs #5533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Calling `canonicalize!` updates the URI object. When the URI is frozen, this results in error `<FrozenError: can’t modify frozen RDF::URI…>` The `canonicalize`, defined in `RDF::URI` makes a copy of the URI object first and then calls `canonicalize!`
elrayle
force-pushed
the
5493_canonical_error
branch
from
7b75d47
to
8b43cbf
Compare
cjcolvar
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
canonicalize!updates the URI object. When the URI is frozen, this results in error<FrozenError: can’t modify frozen RDF::URI…>The
canonicalize, defined inRDF::URI, makes a copy of the URI object first and then callscanonicalize!refs #5254; refs #5493
This issue was introduced in PR #5254. And it is a blocker for follow-on work in PR #5493.
@samvera/hyrax-code-reviewers