Index fields to match ActiveFedora-based models #5548
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcolvar
force-pushed
the
admin_set_work_count
branch
from
0e05f28
to
f5ddd8c
Compare
cjcolvar
force-pushed
the
admin_set_work_count
branch
from
7d2c261
to
1fcbdf1
Compare
elrayle
reviewed
Mar 18, 2022
| # @return [Object] the default model mapper | ||
| def default_model_mapper | ||
| @default_model_mapper ||= ActiveFedora.model_mapper unless disable_wings | ||
| end |
There was a problem hiding this comment.
What is default_model_mapper if disable_wings is true?
elrayle
reviewed
Mar 18, 2022
| @@ -75,7 +75,7 @@ def work? | |||
| end | |||
|
|
|||
| # Method to return the model | |||
| def hydra_model(classifier: ActiveFedora.model_mapper) | |||
| def hydra_model(classifier: Hyrax.config.default_model_mapper) | |||
| first('has_model_ssim')&.safe_constantize || | |||
| classifier.classifier(self).best_model | |||
There was a problem hiding this comment.
What happens if default_model_mapper isn't set, which appears to happen if disable_wings is true?
elrayle
reviewed
Mar 18, 2022
cjcolvar
force-pushed
the
admin_set_work_count
branch
from
9acc610
to
c1c80fa
Compare
|
This issue has been automatically marked as stale because it has not had activity for 30 days. It will be closed if no further activity occurs within 14 days. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5497
This PR ballooned and isn't done yet since I'm still working on bringing in some feature tests. This will probably be broken down into smaller more focused PRs.
@samvera/hyrax-code-reviewers