rework CollectionMembershipValidator to skip overwriting collections #5615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i think it would be a good idea to write further tests for the validator. without unit tests for its behavior i think it could become hard to understand its requirements. |
no-reply
force-pushed
the
collection-validation
branch
3 times, most recently
from
903416e
to
6314a77
Compare
no-reply
force-pushed
the
collection-validation
branch
2 times, most recently
from
43eb185
to
360656d
Compare
|
Summary of Slack discussion. See PR #5448 which added the validator. There was a good bit of discussion around how to populate the collections. |
no-reply
force-pushed
the
collection-validation
branch
from
2b2a8bb
to
6bd214e
Compare
added 4 commits
May 11, 2022 10:40
the validator should limit itself to validating that the collections are allowed. whether or not validation is ever run, `#sync` should apply the form values to the target resource. ensure this happens by moving the value population behavior into a reform populator. without this work, the `Hyrax::CollectionMembershipValidator` was erasing existing collection membership. validators should never change the records being validated.
i had missed in the previous commit that there was an existing set of specs just slightly out of path. this merges the two and drops the expectations for the now removed behavior.
check that the correct error is populated.
the prior implementation of this validator ignored and overwrote existing collections. the forms don't expand existing `member_of_collection_ids` into attributes for submission, so it's important that we validate membership based both on the existing ids AND any new submitted attributes. the newer implementation handles this case, so this adds a regression test for the requirement.
dunn
approved these changes
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the validator should limit itself to validating that the collections are
allowed.
whether or not validation is ever run,
#syncshould apply the form values tothe target resource. ensure this happens by moving the value population behavior
into a reform populator.
without this work, the
Hyrax::CollectionMembershipValidatorwas erasingexisting collection membership. validators should never change the records being
validated.
@samvera/hyrax-code-reviewers