Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to ruby 2.7.5 and alpine 3.15 for base image #5629

Merged
merged 1 commit into from May 13, 2022
Merged

bump to ruby 2.7.5 and alpine 3.15 for base image #5629

merged 1 commit into from May 13, 2022

Conversation

orangewolf
Copy link
Member

rebasing #5451; Third time is the charm?

cc: @no-reply

Suggestion to add to release notes for this version

Update Ruby and Alpine version for the Docker images

There is a change in Ruby 2.7.5 that makes the very obsolete require 'enumerator' call fail. This require hasn't been necessary since ruby 1.8.7 was released, but was common practice for some time. Ruby gems like oai and edtf have not been updated to support Ruby 2.7.5 yet, so that may be a factor in merging this code. We use the following patch to make those libraries work:

sed -i '/require .enumerator./d' /usr/local/bundle/gems/oai-1.1.0/lib/oai/provider/resumption_token.rb && \
sed -i '/require .enumerator./d' /usr/local/bundle/gems/edtf-3.0.5/lib/edtf.rb

https://github.com/orgs/samvera/teams/hyrax-code-reviewers

@dunn dunn merged commit d2d5479 into main May 13, 2022
@dunn dunn deleted the alpine-v branch May 13, 2022 16:56
@orangewolf
Copy link
Member Author

yay! thank you both

@dlpierce dlpierce added the notes-container Release Notes: Docker, Helm, etc label Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-container Release Notes: Docker, Helm, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants