Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address 5680 file manager layout #5696

Merged
merged 2 commits into from Jun 15, 2022
Merged

Address 5680 file manager layout #5696

merged 2 commits into from Jun 15, 2022

Conversation

mathewjordan
Copy link
Member

@mathewjordan mathewjordan commented Jun 15, 2022 •
edited

What does this do?

This cleans up the File Manager view for Bootstrap 4.

image

  • A spacing div on the main viewer no longer needed has been removed.
  • A wrapping .row class has been added.
  • Sortable grid now renders in a 3 column layout
  • The .grid layout for the sortable list items now uses the BS4 utility classes of d-flex and flex-wrap
  • Thumbnail images have a max-width of 100% to not overflow their cards

@mathewjordan mathewjordan self-assigned this Jun 15, 2022
@mathewjordan mathewjordan linked an issue Jun 15, 2022 that may be closed by this pull request
File Manager layout is compressed to a single column (Bootstrap 4) #5680
Closed
eporter23
eporter23 approved these changes Jun 15, 2022
View reviewed changes
Copy link
Contributor

@eporter23 eporter23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mathewjordan mathewjordan merged commit 1620b67 into bl7boot4rails6 Jun 15, 2022
@mathewjordan mathewjordan deleted the 5680-file-manager-layout branch June 15, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eporter23 eporter23 eporter23 approved these changes

@bwatson78 bwatson78 Awaiting requested review from bwatson78

@adamjarling adamjarling Awaiting requested review from adamjarling

Assignees

@mathewjordan mathewjordan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File Manager layout is compressed to a single column (Bootstrap 4)
2 participants
@mathewjordan @eporter23