backport: don't load_and_authorize a model when indexing Embargoes #5815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunn
approved these changes
Aug 25, 2022
this code doesn't need to execute for `index`, and only works by co-incidence (since anyone whon can :index `Hydra::AccessControls::Embargo`, can also index `ActiveFedora::Base`). this might not be true for other models, or when apps have customized their Ability code, so it's strictly incorrect.
no-reply
force-pushed
the
backport-5809
branch
from
4a20ccc
to
2c5eba5
Compare
no-reply
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #5809 to 3.x
@samvera/hyrax-code-reviewers