DownloadsController Valkyrie support #5877
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlpierce
force-pushed
the
5794-download_file
branch
from
9329559
to
2602ad9
Compare
dlpierce
force-pushed
the
5794-download_file
branch
from
2602ad9
to
8fc0782
Compare
workflows still support both AF and Valkyrie, and workflows triggered from the Actor Stack initializer step still passes through AF objects, but this controller had be cut over completely to Valkryie. this impacts users with custom workflow steps. reinstating ActiveFedora support allows applications to choose when to migrate their existing custom workflows.
curation_concern here *should* have #human_readable_type defined, but is is lost somehow. I think this is from the Wings conversion. Luckily, all that method does is call the class method, so let's do that here to avoid the problem.
Add configuration option solr_default_method for use in specifying a default http method across blacklight and activefedora
Add maintenance policy document
Don't throw an error if depositor field isn't present
Prior to this commit, we had inconsistent method interfaces for the two IIIF presenters. Further, we also had the case where the `hostname` and `ability` were not "public", even though we had public writer methods. With this commit, we normalize that.
…ndefined-part-deux always force original_name to UTF-8 encoding
Expanding method interface
…5953) * Update README per Developer Onboarding WG edits [skip ci] Draft changes: https://docs.google.com/document/d/1zwdMdCLp9pqljK-nzVK4iAH-eWQdEZ-rFUtAA-Y4gJk/edit# * Adjusting TOC and adding link to maintenance policy * Adjusting section title * Section heading update * Fixing Samvera wiki link * Adjusting list items
Limit redlock to versions < 2.0, as these cause sidekiq jobs to fail
[skip ci]
* use valkyrie 3.x * Install lsof needed by shared valkyrie spec --------- Co-authored-by: Daniel Pierce <dlpierce@indiana.edu>
This resolves an issue where Rails::Generators::Base is not autoloaded leading to an error: NoMethodError: undefined method `subclasses' for Rails::Generators:Module The require for rails/generators/actions isn't needed because rails/generators autoloads it.
Require rails/generators explicitly
display on work page bibliographic_citation
…ly on user profile (#5965) Co-authored-by: Daniel Pierce <dlpierce@indiana.edu>
* add failing test to demonstrate bug * Remove parameters from the context being passed to the CollectionService so that it does not inherit any user provided filters being applied to work results
* Add all the same data to media display download links as is present on the fileset list download link, to resolve file-set-in-work-download events not having work ids * Allow an analytics id be returned * Tests need presenters
remove funny display when batch loading files.
display banner and logo file and info at file selection.
place radio button to right of collection type in modal.
Updates to CircleCI config
Dispatch workflow events to samvera-labs/nurax instead of curationexperts/nurax
Kubernetes 1.25 drops support for apis used by the solr/zk charts in the versions referenced here. use the latest chart version for compatibility.
orangewolf
reviewed
Mar 21, 2023
| file_metadata = find_file_metadata(file_set: file_set, use: use) | ||
| file = Hyrax.storage_adapter.find_by(id: file_metadata.file_identifier) | ||
| prepare_file_headers_valkyrie(metadata: file_metadata, file: file) | ||
| file.rewind |
There was a problem hiding this comment.
does this mean the whole file is loaded in to memory at this point? /cc @no-reply
…in file downloads
…into 5794-download_file
|
I propose closing this in favor of #5987 |
This was referenced Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5794 ; Depends on merge of #5626
Adopts surfliner's DownloadsController and uses it when using valkyrie. Allows download of files stored in a valkyrie storage adapter.