Backport improvements to FileSet controllers and views #5898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These definitions date back to commit eb9d5cb in May 2015, before the adoption of `hyrax/base/form_permission` for actually rendering this form out (by a different name, in commit f77f4d4, Dec 2015). They don’t appear to do anything now and are incompatible with the newer Hyrax permission model. The need for `depositor` was removed somewhat later, in commit 70ff2ee (Feb 2021).
The “visibility component” form used on the Edit Work page is much nicer and more robust than the “form permission” component used by the Edit File(Set) page. This commit substitutes the former for the latter to make keeping these components in sync easier. Notes: - The `hyrax/base/form_permission` component is still used for batch editing; I’m not as familiar with that part of the codebase but presumably a similar substitution could be made there. - Not all permissions tabs include a “Visibility” section; the Edit Work page puts Visibility not in the tab but in the Save Work component. Consequently, in the Javascript it is an option when constructing a `PermissionControl` whether to include a `VisibilityComponent` or not. - The “Edit Work” page displays the “Visibility” legend slightly differently from the FileSet Permissions tab; this behaviour is now toggleable in the partial by setting `save_work` when rendering.
…ehavior#to_presenter
no-reply
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the changes in #5889, #5892 & #5895, which improve the controllers and views pertaining to FileSet editing in preparation for Valkyrization. (Note #5895 had minor conflicts.)