Additional changes for graph indexer backport #5916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangewolf
approved these changes
Nov 22, 2022
bwatson78
approved these changes
Nov 22, 2022
4 tasks
jeremyf
added a commit
to scientist-softserv/adventist-dl
that referenced
this pull request
Nov 29, 2022
Prior to this commit, we had disabled the logic for indexing the parent child relationships of objects. This results in broken behavior regarding nesting collections and works. Were we to enable the "classic" strategy for indexing, we created significant (and known) performance issues. With this commit, we are taking code that was backported to the 3.x branch of Hyrax via [samvera/hyrax#5858][5858] and [samvera/hyrax#5916][5916] and projecting that onto the 2.9.x implementation. This projection means that we are not directly backporting but instead structuring the code such that if you include it, it assumes you using SOLR's native graph indexing. The aforementioned PRs put those changes behind a configuration variable; which is not something that makes sense given this "hack". This PR aims to resolve three issues, which by their nature, are inter-related. The issues are: - [x] Adding works to a collection [#59][59] - [x] Backporting graph indexing [#68][68] - [ ] Adding a collection to another collection [#70][70] [59]:https://github.com/scientist-softserv/adventist-dl/issues/59 [68]:https://github.com/scientist-softserv/adventist-dl/issues/68 [70]:https://github.com/scientist-softserv/adventist-dl/issues/70 [5858]:samvera/hyrax#5858 [5916]:samvera/hyrax#5916
3 tasks
jeremyf
added a commit
to scientist-softserv/adventist-dl
that referenced
this pull request
Nov 29, 2022
Prior to this commit, we had disabled the logic for indexing the parent child relationships of objects. This results in broken behavior regarding nesting collections and works. Were we to enable the "classic" strategy for indexing, we created significant (and known) performance issues. With this commit, we are taking code that was backported to the 3.x branch of Hyrax via [samvera/hyrax#5858][5858] and [samvera/hyrax#5916][5916] and projecting that onto the 2.9.x implementation. This projection means that we are not directly backporting but instead structuring the code such that if you include it, it assumes you using SOLR's native graph indexing. The aforementioned PRs put those changes behind a configuration variable; which is not something that makes sense given this "hack." This PR aims to resolve three issues, which by their nature, are inter-related. The issues are: - [x] Adding works to a collection [#59][59] - [x] Backporting graph indexing [#68][68] - [x] Adding a collection to another collection [#70][70] [59]: https://github.com/scientist-softserv/adventist-dl/issues/59 [68]: https://github.com/scientist-softserv/adventist-dl/issues/68 [70]: https://github.com/scientist-softserv/adventist-dl/issues/70 [5858]: samvera/hyrax#5858 [5916]: samvera/hyrax#5916
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional fixes to #5858
With the prior backport, collection nesting does not work with the graph indexer. This fixes remaining pieces.
Changes proposed in this pull request:
@samvera/hyrax-code-reviewers