Backport 5915 reinstate support for ActiveFedora to WorkflowActionsController #5927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
workflows still support both AF and Valkyrie, and workflows triggered from the Actor Stack initializer step still passes through AF objects, but this controller had be cut over completely to Valkryie. this impacts users with custom workflow steps. reinstating ActiveFedora support allows applications to choose when to migrate their existing custom workflows.
curation_concern here *should* have #human_readable_type defined, but is is lost somehow. I think this is from the Wings conversion. Luckily, all that method does is call the class method, so let's do that here to avoid the problem.
jeremyf
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #5915 to 3.x
@samvera/hyrax-code-reviewers