5575 item actions edit #6090
5575 item actions edit #6090
Conversation
there was an error because `#representative_id=` did not exist. refer to #5575 for more details. co-authored-by: braydon <braydon.justice@1268456bcltd.ca>
alishaevn
force-pushed
the
5575-item-actions-edit
branch
from
d6aa7b1
to
c12b8fc
Compare
the license attribute is not required in Hyrax::Forms::WorkForm and is not even available as an editable field on the Hyrax::Forms::FileSetForm. so it feels unnecessary to require it on file sets. co-authored-by: braydon <braydon.justice@1268456bcltd.ca>
| @@ -16,7 +16,7 @@ attributes: | |||
| type: string | |||
| multiple: true | |||
| form: | |||
| required: true | |||
| required: false | |||
There was a problem hiding this comment.
the license attribute is not required in Hyrax::Forms::WorkForm and isn't even available as an editable field on the Hyrax::Forms::FileSetForm, so @sephirothkod and I decided it was unnecessary to require for file sets. removing that requirement allowed change_set.validate(attributes) in Hyrax::FileSetsController#update_metadata to work.
ref: (two different comments)
| @@ -6,7 +6,7 @@ class FileSetEditForm | |||
|
|
|||
| delegate :depositor, :permissions, :human_readable_type, to: :model | |||
|
|
|||
| self.required_fields = [:title, :creator, :license] | |||
| self.required_fields = [:title, :creator] | |||
There was a problem hiding this comment.
the license attribute is not required in Hyrax::Forms::WorkForm and isn't even available as an editable field on the Hyrax::Forms::FileSetForm, so @sephirothkod and I decided it was unnecessary to require for file sets. removing that requirement allowed change_set.validate(attributes) in Hyrax::FileSetsController#update_metadata to work.
ref: (two different comments)
|
the |
Fixes
Summary
fix the ability to edit valkyrie backed file sets
Guidance for testing, such as acceptance criteria or new user interface behaviors:
Type of change (for release notes)
Detailed Description
there was an error because
#representative_id=did not exist. refer to https://github.com/samvera/hyrax/issues/5575\#issuecomment-1581512555 for more details@samvera/hyrax-code-reviewers