Save permission attributes for FileSet edit. #6236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey! this looks great! |
lsitu
force-pushed
the
file-set-permission-update
branch
from
b9c8a26
to
8e82ef6
Compare
lsitu
force-pushed
the
file-set-permission-update
branch
from
8e82ef6
to
3734046
Compare
|
@no-reply Thanks for the quick review. I've added unique tests and integration tests for the file_set.update transaction. I think the PR is ready now. |
lsitu
changed the title
no-reply
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #6177 ; refs #6177
Summary
Save permission attributes with file_set.update transaction during file update.
@samvera/hyrax-code-reviewers