test behavior after a published Fixity check failure on Valkyrie #6259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
added
notes-valkyrie
added 2 commits
August 29, 2023 21:12
the FixityCheckFailureService was, for some reason, reporting the FileSet's `original_file` URI as the failed fixity check regardless of which file in the FileSet was actually checked. the audit log data has the actual information, it's just the notifications that were wrong.
if a Valkyrie Fixity service (to be invented) fails, it should be able to publish an event to be picked up by `FileSetLifecycleNotificationListener` and a notification can be published. this updates the tests for the fixity failure notification path to avoid testing AF behavior when Wings is disabled, and to add support for Valkyrie to the code path.
no-reply
force-pushed
the
fixity-failure
branch
from
0e7dd9b
to
1f560ec
Compare
dlpierce
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if a Valkyrie Fixity service (to be invented) fails, it should be able to
publish an event to be picked up by
FileSetLifecycleNotificationListenerand anotification can be published.
this updates the tests for the fixity failure notification path to avoid testing
AF behavior when Wings is disabled, and to add support for Valkyrie to the code
path.
Changes proposed in this pull request:
original_filefailed, even when another file's fixity was checked@samvera/hyrax-code-reviewers