only use specialized Wings::WorkSearchBuilder if Wings is enabled
#6261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`WorksControllerBehavior` offers the option to use it with `curation_concern_type` that is a `Valkyrie::Resource`. in the event that one does this, and `Wings` is turned on, it's necessary to provide a custom search_builder_class to the controller to allow it to find resources indexed as their mapped `ActiveFedora` objects. that is, Valkyrie objects saved by Wings are indexed by ActiveFedora using model names provided by AF. none of this is needed if Valkyrie is handling the indexing, and the normal search builder can be used in that case. so don't try to setup this class for `.koppie` and in other cases where Wings is not in use.
no-reply
added
notes-valkyrie
hackartisan
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WorksControllerBehavioroffers the option to use it withcuration_concern_typethat is aValkyrie::Resource. in the event that one does this, andWingsis turned on, it's necessary to provide a custom search_builder_class to the controller to allow it to find resources indexed as their mappedActiveFedoraobjects.that is, Valkyrie objects saved by Wings are indexed by ActiveFedora using model names provided by AF.
none of this is needed if Valkyrie is handling the indexing, and the normal search builder can be used in that case. so don't try to setup this class for
.koppieand in other cases where Wings is not in use.@samvera/hyrax-code-reviewers