dassie/koppie alignment and added bundle caching #6325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the same images for dassie/koppie dependent services. - Don't build an image for db_migrate, reuse the app image. - Use `dev-entrypoint.sh` to copy gems from image build to `/app/bundle` volume to speed up runtime `bundle install`. Only set in compose to avoid affecting CircleCI build. - `/bin` is volume mounted to allow easier dev of entrypoints, etc.
- Use the same images for dassie/koppie dependent services. - Don't build an image for db_migrate, reuse the app image. - Use `dev-entrypoint.sh` to copy gems from image build to `/app/bundle` volume to speed up runtime `bundle install`. Only set in compose to avoid affecting CircleCI build. - `/bin` is volume mounted to allow easier dev of entrypoints, etc.
dlpierce
force-pushed
the
dc-cached-bundle
branch
from
1c1bf0e
to
76dec5f
Compare
…nto dc-cached-bundle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
dassie/koppie alignment and added bundle caching
Guidance for testing, such as acceptance criteria or new user interface behaviors:
docker compose down -vand remove any Gemfile.*.lock files in hyrax root and .dassie/.koppie)Changes proposed in this pull request:
dev-entrypoint.shto copy gems from image build to/app/bundlevolume to speed up runtimebundle install. Only set in compose to avoid affecting CircleCI build./binis volume mounted to allow easier dev of entrypoints, etc.@samvera/hyrax-code-reviewers