Fix based_near/Location for resource models #6335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlpierce
added
notes-minor
Access location service via Hyrax config to allow easier mock responses in specs Add form (pre)populator to handle the data sent/received from the controlled vocabulary input Auto-include any properly named form field behaviors
dlpierce
force-pushed
the
valk-location
branch
from
60026f3
to
b45b1ff
Compare
jeremyf
reviewed
Oct 4, 2023
| @@ -14,7 +14,13 @@ def solrize | |||
| end | |||
|
|
|||
| def full_label | |||
| Hyrax::LocationService.new.full_label(rdf_subject.to_s) | |||
| location_service.full_label(rdf_subject.to_s) | |||
jeremyf
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #6277
Summary
Add form (pre)populator to handle the data sent/received from the controlled vocabulary input
Guidance for testing, such as acceptance criteria or new user interface behaviors:
Changes proposed in this pull request:
@samvera/hyrax-code-reviewers