Valkyrization: Fix failing tests in solr_service_spec.rb #6463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelemlih
force-pushed
the
abel-fix_solr_service_spec
branch
from
7c3739f
to
c92a024
Compare
abelemlih
force-pushed
the
abel-fix_solr_service_spec
branch
from
c92a024
to
59bd68d
Compare
abelemlih
changed the title
dlpierce
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes failing tests in
spec/services/hyrax/solr_service_spec.rbwhen Valkyrie is usedSummary
In
/app/services/hyrax/solr_service.rb, the parameters used in both theGETandPOSTrequests do not includeqt: 'standard'whenuse_valkyrieistrue. The tests inspec/services/hyrax/solr_service_spec.rbassume the use of theqt: 'standard'parameters when Valkyrie is both used and not. In this PR, I edit the tests to use different sets of parameters depending on the use of Valkyrie.Type of change (for release notes)
notes-valkyrieValkyrie ProgressChanges proposed in this pull request:
qt: 'standard'parameter only when Valkyrie is not used for all tests#pingtests to mock the response of the ping request when Valkyrie is not used@samvera/hyrax-code-reviewers