Marks test suite as ActiveFedora-only because the alternative Valkyrie form class has its own suite. #6494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e form class has its own suite.
bwatson78
force-pushed
the
updates_admin_set_form_spec
branch
from
261f632
to
aed261c
Compare
dlpierce
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes
spec/forms/hyrax/forms/admin_set_form_spec.rb.Summary
Marks test suite as ActiveFedora-only because the alternative Valkyrie form class has its own suite.
Type of change (for release notes)
notes-valkyrieValkyrie ProgressDetailed Description
The Valkyrie-specific Admin Set form already has a test suite (
hyrax/spec/forms/hyrax/forms/administrative_set_form_spec.rb).@samvera/hyrax-code-reviewers