Valkyrizes spec/services/hyrax/statistics/depositors/summary_spec.rb.
#6528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
bwatson78
force-pushed
the
updates_statistics_depositors_summary_spec
branch
from
3bfe0b9
to
2cf4756
Compare
|
Oh, didn't realize that was an option. I'll look for examples. |
bwatson78
force-pushed
the
updates_statistics_depositors_summary_spec
branch
from
1be0dd1
to
fbaeadb
Compare
dlpierce
approved these changes
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes
spec/services/hyrax/statistics/depositors/summary_spec.rb.Summary
Valkyrizes
spec/services/hyrax/statistics/depositors/summary_spec.rb.Type of change (for release notes)
notes-valkyrieValkyrie ProgressDetailed Description
Swaps between ActiveFedora and Valkyrie objects depending on environment. Tried using Valkyrie objects only, but the indexing was defaulting to
Valkyrie::Indexing::NullIndexingAdapterwithin the Dassie environment, which is essentially pass-through, making it hard to manipulate with thebeforestatement.@samvera/hyrax-code-reviewers