♻️ Extract Action Logic for improved composibility #6644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, there was a precarity regarding the extensibility of the create action for valkyrie objects. The create method had several interacting objects, which made downstream composibility harder to implement (without completely overriding the action's behavior). Downstream could: 1. Provide a different container for transactions 2. Inject additional steps into the transaction container, and those steps could require step args. 3. Remove/replace one of the transactions that has a step arg (which would then raise an error). In all of these cases, the size of the original method makes for harder downstream extensibility. With this commit, I'm extracting an action object, putting forward a minimum amount of work so we can discuss the approach. This should be considered a noop change as I'm moving where the logic happens. If we deem that this is a good approach, I'd envision extracting some of the work controller behavior specs into the given action. I would also anticipate extracting the update and delete actions.
jeremyf
force-pushed
the
create-refactor-for-valkyrie-create-work-action
branch
from
b2382b1
to
da6a221
Compare
dlpierce
reviewed
Jan 29, 2024
dlpierce
approved these changes
Jan 30, 2024
jeremyf
added a commit
that referenced
this pull request
Jan 30, 2024
* main: ♻️ Extract Action Logic for improved composibility (#6644) Prevent Wings from loading when disabled use rspec filter to exclude :active_fedora tags configure Solr for koppie ci: add koppie build and test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, there was a precarity regarding the extensibility of the create action for valkyrie objects.
The create method had several interacting objects, which made downstream composibility harder to implement (without completely overriding the action's behavior). Downstream could:
In all of these cases, the size of the original method makes for harder downstream extensibility.
With this commit, I'm extracting an action object, putting forward a minimum amount of work so we can discuss the approach.
This should be considered a noop change as I'm moving where the logic happens.
If we deem that this is a good approach, I'd envision extracting some of the work controller behavior specs into the given action. I would also anticipate extracting the update and delete actions.