Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Zeitwerk code loading #6682

Merged
merged 4 commits into from Feb 8, 2024
Merged

Fixes for Zeitwerk code loading #6682

merged 4 commits into from Feb 8, 2024

Conversation

dlpierce
Copy link
Contributor

@dlpierce dlpierce commented Feb 8, 2024

Summary

Fixes issues discovered while attempting to use an application in zeitwerk mode.

Changes proposed in this pull request:

  • Moves module methods of the form self.MyClass(class_name) out of the file containing the MyClass class. Zeitwerk did not like having both in one file.
  • Remove empty files (zeitwerk errors if it cannot find appropriately named code inside.
  • Use ACL in class names to meet zeitwerk expectations.

@dlpierce dlpierce added the notes-bugfix Release Notes: Fixed a bug label Feb 8, 2024
@jeremyf jeremyf merged commit 5f1b3cd into main Feb 8, 2024
6 checks passed
@jeremyf jeremyf deleted the zeitwerk branch February 8, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes-bugfix Release Notes: Fixed a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants