✂ Remove useless test #6688
Merged
✂ Remove useless test #6688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nowhere in the code, aside from what we're removing, does the phrase `"Test Private Document"` show up. Also, there's no setup for this test, meaning we aren't creating documents and were likely once upon a time relying on another spec to run and not clean itself up. It was [1743c7b][1] that removed any creation of documents. Below is a Ripgrep search looking for any possible matches: ``` ❯ rg "Test.*Document" -i spec spec/controllers/hyrax/generic_works_controller_spec.rb 13: describe 'integration test for suppressed documents' do 31: describe 'integration test for depositor of a suppressed documents without a workflow role' do spec/controllers/hyrax/file_sets_controller_spec.rb 507: describe 'integration test for suppressed documents' do 937: describe 'integration test for suppressed documents' do spec/features/browse_dashboard_works_spec.rb 19: title: ["Test Document MP3"], 60: expect(page).to have_link("Display all details of Test Document MP3", ``` [1]: 1743c7b569b3#diff-85199f339ea08f1dcaa588f9d29c68cd1209956fef816a8e1c92221bd0f6af45L9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nowhere in the code, aside from what we're removing, does the phrase
"Test Private Document"show up. Also, there's no setup for this test, meaning we aren't creating documents and were likely once upon a time relying on another spec to run and not clean itself up.It was 1743c7b569b3 that removed any creation of documents.
Below is a Ripgrep search looking for any possible matches:
@samvera/hyrax-code-reviewers