Skip to content

Commit

Permalink
Merge pull request #307 from samvera/geonames-https
Browse files Browse the repository at this point in the history
Update Geonames URIs to https
  • Loading branch information
Julie Allinson committed Dec 23, 2019
2 parents 105a185 + fb9f228 commit 9b41dfc
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/qa/authorities/geonames.rb
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ def find_url(id)
def parse_authority_response(response)
response['geonames'].map do |result|
# Note: the trailing slash is meaningful.
{ 'id' => "http://sws.geonames.org/#{result['geonameId']}/",
{ 'id' => "https://sws.geonames.org/#{result['geonameId']}/",
'label' => label.call(result) }
end
end
Expand Down
4 changes: 2 additions & 2 deletions spec/lib/authorities/geonames_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@

context "with default label" do
it "has id and label keys" do
expect(subject.first).to eq("id" => 'http://sws.geonames.org/2088122/',
expect(subject.first).to eq("id" => 'https://sws.geonames.org/2088122/',
"label" => "Port Moresby, National Capital, Papua New Guinea")
expect(subject.last).to eq("id" => 'http://sws.geonames.org/377039/',
expect(subject.last).to eq("id" => 'https://sws.geonames.org/377039/',
"label" => "Port Sudan, Red Sea, Sudan")
expect(subject.size).to eq(10)
end
Expand Down

0 comments on commit 9b41dfc

Please sign in to comment.