Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to migrations to support rails >= 5.1 #154

Merged
merged 1 commit into from
Sep 25, 2017

Conversation

elrayle
Copy link
Contributor

@elrayle elrayle commented Sep 25, 2017

For all migrations, this PR adds [4.2] as the version under which the migrations were created. A version number is required for migrations to run under Rails 5.1 and later. It cannot be present in migrations run under Rails < 5.0.

A branch, named stable_1.2_for_rails_4.2 was created to allow bug fixes if needed to be made available for Rails 4.2.

Release 1.2 is the last one that supports Rails 4.2. A release will be made with the migration changes in this PR and released as 1.3. The release notes for both will be updated to reflect the Rails versions supported.

Copy link

@no-reply no-reply left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Per discussion on Slack, my preference is to release this as 2.0.0.

@no-reply no-reply merged commit 809bbc5 into master Sep 25, 2017
@no-reply no-reply deleted the migrations_for_5.1 branch September 25, 2017 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants