Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swagger API documentation for linked data API #175

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Conversation

elrayle
Copy link
Contributor

@elrayle elrayle commented Sep 26, 2018

Adds an installer to add swagger API docs for the linked data module. The doc is installed in public/apidoc directory of the app including QA.

To view what the apidoc installer will do: (from the app including QA >= 2.1.2)

rails g qa:apidoc -h

To run the apidoc installer: (from the app including QA >= 2.1.2)

rails g qa:apidoc

This will install the docs in your app at... public/qa/apidoc

To view the API documentation:

https://YOUR_APP_HOST/qa/apidoc/

NOTE: The trailing / is required.

@elrayle elrayle self-assigned this Sep 26, 2018
@elrayle elrayle force-pushed the swagger_api_doc branch 2 times, most recently from 467bb01 to bc9e4c2 Compare September 30, 2018 18:58
@elrayle elrayle requested a review from afred September 30, 2018 19:05
@elrayle elrayle changed the title [WIP] Add Swagger API documentation for linked data API Add Swagger API documentation for linked data API Sep 30, 2018
@elrayle elrayle changed the title Add Swagger API documentation for linked data API [WIP] Add Swagger API documentation for linked data API Sep 30, 2018
@elrayle elrayle removed the request for review from afred September 30, 2018 19:06
@elrayle elrayle requested a review from afred September 30, 2018 21:20
@elrayle elrayle changed the title [WIP] Add Swagger API documentation for linked data API Add Swagger API documentation for linked data API Sep 30, 2018
…g qa

Generator copies Swagger UI files and linked data API config to public/qa/apidoc.
View API docs at https://YOUR_APP_HOST/qa/apidoc/
Copy link
Contributor

@afred afred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Coveralls is warning about a 2.8% decrease in coverage. This is due to an added Generator that does not have tests, and Hyrax (for better or worse) does not have tests for its generators.

While QA has some coverage issues that need to be addressed, after discussion with @elrayle on Slack, we decided to not let those issues block this PR. Additional tickets can be made for improving coverage.

@afred afred merged commit 86f048a into master Oct 1, 2018
@afred afred deleted the swagger_api_doc branch October 1, 2018 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants