Remove agrovoc linked data authority #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URL for the AgroVoc API has changed twice in the last year and a half. It is undesirable to have to update QA for the changing API requirements. The AgroVoc configuration will continue to be maintained at https://github.com/LD4P/linked_data_authorities/tree/master/qa_agrovoc.
elrayle
force-pushed
the
remove_agrovoc
branch
from
53702ae
to
8a8327e
Compare
elrayle
commented
Nov 19, 2018
| @@ -9,5 +9,5 @@ | |||
| # action '/reload/linked_data/authorities?auth_token=YOUR_AUTH_TOKEN_DEFINED_HERE' without | |||
| # requiring a restart of rails. By default, reloading through the browser is not allowed | |||
| # when the token is nil or blank. Change to any string to control who has access to reload. | |||
| # config.authorized_reload_token = YOUR_AUTH_TOKEN_DEFINED_HERE | |||
| # config.authorized_reload_token = 'YOUR_AUTH_TOKEN_DEFINED_HERE' | |||
There was a problem hiding this comment.
Sneaking in a quick fix to make this a more accurate example since the token users change to should be a string. No code impact with this change.
elrayle
commented
Nov 19, 2018
| expect(response).to be_successful | ||
| expect(response.content_type).to eq 'application/ld+json' | ||
| expect(JSON.parse(response.body).keys).to match_array ["@context", "@graph"] | ||
| end |
There was a problem hiding this comment.
These tests were covered using the Agrovoc auth. They were moved to the oclc_fast tests to maintain coverage of that functionality.
|
NOTE: I confirmed that any functionality that was tested solely under tests related to agrovoc were moved to another authority to avoid a drop in test coverage. |
revgum
approved these changes
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL for the AgroVoc API has changed twice in the last year and a half. It is undesirable to have to update QA for the changing API requirements. The AgroVoc configuration will continue to be maintained at LD4P/linked_data_authorities/qa_agrovoc.
NOTE: At this writing, the configuration at LD4P Linked Data Authorities is broken. It will be fixed as soon as the AgroVoc technical problems are resolved.