Extract out search results mapping to services #192
Conversation
elrayle
commented
Dec 17, 2018
elrayle
commented
- adds GraphMapperService that selects out a list of predicate-values from an RDF graph for a single URI
- adds a SearchMapperService that uses the GraphMapperSerivce for each search result
| @@ -109,14 +85,6 @@ def wrap_labels(labels) | |||
| lbl = '[' + lbl + ']' if labels.size > 1 | |||
| lbl | |||
| end | |||
|
|
|||
| def sort_search_results(json_results) | |||
There was a problem hiding this comment.
sort happens in mapper
| search_matches = [] | ||
| graph.subjects.each do |subject| | ||
| next if subject.anonymous? # skip blank nodes | ||
| values = Qa::LinkedData::Mapper::GraphMapperService.map_values(graph: graph, predicate_map: predicate_map, subject_uri: subject) |
There was a problem hiding this comment.
@elrayle Just curious, in cases like this where classes share the same module namespace, is it necessary to fully qualify the class name? The tests pass (for me) with just GraphMapperService instead of the qualified form - is there a runtime error that could still arise? Just wondering, those lines get really long with long module names and parameters.
There was a problem hiding this comment.
@elrayle I see your point on potential name conflicts. I would imagine the behavior to be that the class in the same namespace would be sent the message first, but that could be very dependent upon class loading configuration and even Ruby or Rails versions. Probably not worth the risk to save a few characters of line length.
Two benefits of this approach: * simplify the code by removing long module/class refs in methods * simplify future refactors that might want to swap out a service by having a single reference to external classes at the top of the class using them
elrayle
force-pushed
the
ld_refactor_mapping
branch
from
5bbbce5
to
eca3fa2
Compare
