process additional context and add to final json results #200
Conversation
elrayle
force-pushed
the
ld_refactor_process_context
branch
from
9b4b434
to
0f4ca35
Compare
elrayle
force-pushed
the
ld_refactor_process_context
branch
5 times, most recently
from
3a73809
to
d40c624
Compare
elrayle
changed the title
| @@ -189,6 +189,11 @@ def jsonld? | |||
| format == 'jsonld' | |||
| end | |||
|
|
|||
| def context? | |||
| context = params.fetch(:context, false) | |||
| context == 'true' ? true : false | |||
There was a problem hiding this comment.
@elrayle Do you care about TRUE or True here?
There was a problem hiding this comment.
Yep... I'll downcase before comparison. Good catch.
| # @param subject_uri [RDF::URI] the subject within the graph for which the values are being extracted | ||
| # @return [<Hash<Symbol><Array<Object>>] mapped context values and information with hash of map key = array of object values for predicates identified in predicate_map. | ||
| # @example value map for a single result | ||
| # {:uri=>[#<RDF::URI:0x3fcff54a829c URI:http://id.loc.gov/authorities/names/n2010043281>], |
There was a problem hiding this comment.
This should start with a [
There was a problem hiding this comment.
I also thing if I am reading the code correctly the example should really look like below. I do not see id, label, altlabel being added in construct context.
[{"group" => "group label,
"property" => "property label",
"values" => ["value 1","value 2"],
"selectable" => true,
"drillable" => false}]
There was a problem hiding this comment.
That is a copy paste error. I'll update the example.
elrayle
force-pushed
the
ld_refactor_process_context
branch
from
d40c624
to
43c689d
Compare
|
|
||
| def context? | ||
| context = params.fetch(:context, 'false') | ||
| context.casecmp('true').zero? |
There was a problem hiding this comment.
Switched to use casecmp based on rubocop recommendation. Applied the same change to jsonld? for consistency.
And one other small cleanup to check for blank? instead of nil? for subauth, which covers more potential non-existing values for subauth.
|
@Cam156 Your requested changes have been made. |
Adds:
Remaining Work after this PR: